fix: correct final whole-branch review findings for 0.6.6 English content
- TRAVELLING spelling: fix TRAVELING -> TRAVELLING in travel-panel.component.html to match UK spelling used everywhere else (world/hunting/combat stores + API error messages) - Grenzwacht -> Border Watch: fix stale German faction display name in reputation-display, reputation.service/controller, turn-in.service specs, and the vertical-slice seed spec test title - Suedtor von Graufurt -> Graufurt South Gate: fix stale ASCII-transliterated German location name in hunting.service.spec.ts - Aschenfelder(n) -> Ashen Fields: fix stale German location name/description in top-bar.component.spec.ts and context-panel.component.spec.ts (key identifiers left untouched) - Fix 7 test titles still describing translated error messages as "German" across world/hunting/inventory/combat store specs - README: update demo location names from German to their current English names (Graufurt South Gate, Burned Road) - item-rarity.enum.ts: fix now-false comment claiming rarity labels are German; the frontend RARITY_LABELS map is English Pure literal-string/comment substitutions; no keys, ids, or logic changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ACkMEDYiwtcfchqKkiUJNX
This commit is contained in:
@@ -606,7 +606,7 @@ describe('seedVisibleVerticalSlice', () => {
|
||||
);
|
||||
});
|
||||
|
||||
it('seeds the Grenzwacht faction', async () => {
|
||||
it('seeds the Border Watch faction', async () => {
|
||||
const reputationFactionRepository = new InMemoryRepository();
|
||||
const dataSource = createDataSource(
|
||||
new InMemoryRepository(),
|
||||
|
||||
@@ -212,7 +212,7 @@ function safeLocation(): LocationDefinition {
|
||||
return {
|
||||
id: SAFE_LOCATION_ID,
|
||||
key: 'south-gate',
|
||||
name: 'Suedtor von Graufurt',
|
||||
name: 'Graufurt South Gate',
|
||||
description: 'A safe gate.',
|
||||
regionKey: 'ashen-fields',
|
||||
minRecommendedLevel: 1,
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
// Mirrors docs/Ashen_Realms_Balancing_Items_Loot_Design_V1.md §19:
|
||||
// Gewöhnlich / Selten / Episch. German labels live in the frontend.
|
||||
// Common / Rare / Epic. Display labels live in the frontend.
|
||||
export enum ItemRarity {
|
||||
COMMON = 'COMMON',
|
||||
RARE = 'RARE',
|
||||
|
||||
@@ -33,7 +33,7 @@ describe('ReputationController', () => {
|
||||
const entries = [
|
||||
{
|
||||
factionKey: 'border-guard',
|
||||
factionName: 'Grenzwacht',
|
||||
factionName: 'Border Watch',
|
||||
reputation: 40,
|
||||
rank: 'STRANGER',
|
||||
rankLabel: 'Stranger',
|
||||
|
||||
@@ -124,7 +124,7 @@ function faction(
|
||||
return {
|
||||
id: FACTION_ID,
|
||||
key: 'border-guard',
|
||||
name: 'Grenzwacht',
|
||||
name: 'Border Watch',
|
||||
description: '',
|
||||
regionKey: 'ashen-fields',
|
||||
enabled: true,
|
||||
@@ -312,7 +312,7 @@ describe('ReputationService', () => {
|
||||
expect(result).toEqual([
|
||||
{
|
||||
factionKey: 'border-guard',
|
||||
factionName: 'Grenzwacht',
|
||||
factionName: 'Border Watch',
|
||||
reputation: 0,
|
||||
rank: 'STRANGER',
|
||||
rankLabel: 'Stranger',
|
||||
@@ -330,7 +330,7 @@ describe('ReputationService', () => {
|
||||
|
||||
expect(result[0]).toEqual({
|
||||
factionKey: 'border-guard',
|
||||
factionName: 'Grenzwacht',
|
||||
factionName: 'Border Watch',
|
||||
reputation: 300,
|
||||
rank: 'KNOWN',
|
||||
rankLabel: 'Known',
|
||||
|
||||
@@ -177,7 +177,7 @@ function faction(
|
||||
return {
|
||||
id: FACTION_ID,
|
||||
key: 'border-guard',
|
||||
name: 'Grenzwacht',
|
||||
name: 'Border Watch',
|
||||
enabled: true,
|
||||
...overrides,
|
||||
} as ReputationFaction;
|
||||
|
||||
Reference in New Issue
Block a user