fix(monsters): finish deleting experienceReward, column included
Design ruling R7 abolishes XP as a concept and says the column goes with it, but no task in the plan actually dropped it -- the plan only dropped characters.experience and combat_rewards.experience_granted. Task 9 removed experienceReward from the seed literals, leaving monster_definitions.experience_reward as a NOT NULL column with no default that nothing supplies. The first monster insert against a real database would have failed on a constraint violation. No suite here could have caught it: none of them connect to Postgres. Drops the column in the slice migration (which has never been run, so amending it in place is correct rather than stacking a second one), removes the entity field, and clears the three test fixtures that still set it. silver_min/silver_max deliberately stay -- spec 15 keeps a direct currency drop available as a lore-valid exception, and XP has no such carve-out. Also retargets the seed idempotency test off renown: 1, which is the seed's own default and so could not distinguish "preserved" from "reset to default". NOTE ON SCOPE: this commit also absorbs a Prettier reformatting pass that was already sitting uncommitted in the working tree, which is why it touches ~59 files. That churn is purely cosmetic line-rewrapping -- verified by inspection, and the suite is green at 267/267 with the build at exactly the 3 expected errors owned by Tasks 10 and 11. The repo is not Prettier-clean at baseline (119 files still flagged), so this was a partial run by an earlier step, not a deliberate repo-wide format. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -115,9 +115,7 @@ describe('WorldService.runLocalInteraction', () => {
|
||||
});
|
||||
|
||||
it('settles travel before resolving which location the character stands at', async () => {
|
||||
const completeTravelIfDue = jest
|
||||
.fn()
|
||||
.mockResolvedValue({ status: 'IDLE' });
|
||||
const completeTravelIfDue = jest.fn().mockResolvedValue({ status: 'IDLE' });
|
||||
const service = createService(
|
||||
location(BURNED_ROAD_ID, BURNED_ROAD_POIS),
|
||||
completeTravelIfDue,
|
||||
@@ -155,6 +153,8 @@ describe('WorldService.runLocalInteraction', () => {
|
||||
it('rejects a navigation hotspot that has no result to reveal', async () => {
|
||||
const service = createService(location(BURNED_ROAD_ID, BURNED_ROAD_POIS));
|
||||
|
||||
await expectRejected(service.runLocalInteraction(CHARACTER_ID, 'hunt-area'));
|
||||
await expectRejected(
|
||||
service.runLocalInteraction(CHARACTER_ID, 'hunt-area'),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -4,7 +4,9 @@ import { WorldService } from './world.service';
|
||||
|
||||
describe('WorldController', () => {
|
||||
it('resolves the current location for the acting character', () => {
|
||||
const getCurrentLocation = jest.fn().mockResolvedValue({ key: 'burned-road' });
|
||||
const getCurrentLocation = jest
|
||||
.fn()
|
||||
.mockResolvedValue({ key: 'burned-road' });
|
||||
const controller = new WorldController({
|
||||
getCurrentLocation,
|
||||
} as unknown as WorldService);
|
||||
|
||||
@@ -2,10 +2,7 @@ import { Injectable, NotFoundException } from '@nestjs/common';
|
||||
import { InjectRepository } from '@nestjs/typeorm';
|
||||
import { Repository } from 'typeorm';
|
||||
import { Character } from '../characters/entities/character.entity';
|
||||
import {
|
||||
calculateDangerRating,
|
||||
DangerRating,
|
||||
} from '../hunting/danger-rating';
|
||||
import { calculateDangerRating, DangerRating } from '../hunting/danger-rating';
|
||||
import { LocationMonster } from '../monsters/entities/location-monster.entity';
|
||||
import { TravelService } from '../travel/travel.service';
|
||||
import { LocationConnection } from './entities/location-connection.entity';
|
||||
@@ -107,9 +104,8 @@ export class WorldService {
|
||||
localArtworkPath: location.localArtworkPath,
|
||||
dangerRating: this.toLocalDangerRating(character, pool),
|
||||
recommendationLabel: this.toRecommendationLabel(location),
|
||||
pointsOfInterest: location.localPointsOfInterest.map(
|
||||
toPointOfInterestDto,
|
||||
),
|
||||
pointsOfInterest:
|
||||
location.localPointsOfInterest.map(toPointOfInterestDto),
|
||||
primaryActions: location.localPrimaryActions,
|
||||
encounterPreview: pool.map((entry) => ({
|
||||
key: entry.monster.key,
|
||||
|
||||
Reference in New Issue
Block a user