logging

tests/sync/test_manager.py

@@ -8,6 +8,7 @@ from app.db.repositories import SystemLogRepository, UserRepository
 from app.garmin.uploader import UploadResult
 from app.mywhoosh.client import MyWhooshDeviceConflictError
 from app.mywhoosh.models import MyWhooshActivity
+from app.notifications.emailer import EmailNotifier
 from app.sync.manager import SyncManager
 from tests.sync.conftest import FakeFitConverter, _create_user
 from tests.sync.fakes import FakeGarminUploader, FakeMyWhooshClient, FakeNotifier
@@ -343,6 +344,44 @@ async def test_email_send_failure_is_recorded_in_system_log_and_does_not_break_s
         assert "alerts@example.com" in entries[0].message
 
 
+@pytest.mark.asyncio
+async def test_unconfigured_smtp_is_recorded_in_system_log_not_silently_dropped(
+    session_factory, cipher, settings
+) -> None:
+    """Regression test: an EmailNotifier with no SMTP_HOST configured skips
+    sending without raising, which used to look identical to "notifications
+    disabled" -- an opted-in user got neither an email nor any trace of why,
+    with nothing to debug from. This must now leave a system log entry."""
+    with session_factory() as session:
+        user = _create_user(session, cipher)
+        user.notify_email_enabled = True
+        user.notification_email = "alerts@example.com"
+        session.commit()
+        user_id = user.id
+
+    unconfigured_notifier = EmailNotifier(
+        host=None, port=587, username=None, password=None, from_address=None, use_tls=True
+    )
+    manager = SyncManager(
+        session_factory=session_factory,
+        credential_cipher=cipher,
+        settings=settings,
+        mywhoosh_factory=lambda token_store: DeviceConflictMyWhooshClient(),
+        garmin_factory=lambda email, password, tokenstore: FakeGarminUploader(),
+        fit_converter=FakeFitConverter(),
+        notifier=unconfigured_notifier,
+    )
+
+    await manager.sync_user(user_id)
+
+    with session_factory() as session:
+        entries = SystemLogRepository(session).list_recent()
+        assert len(entries) == 1
+        assert entries[0].source == "email_notification"
+        assert "SMTP is not configured" in entries[0].message
+        assert "alerts@example.com" in entries[0].message
+
+
 @pytest.mark.asyncio
 async def test_mfa_code_reaches_real_garmin_uploader_via_sync_manager(
     session_factory, cipher, settings, seeded_user: SyncUser